-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributes support for onnx cumsum op #3241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not very sure about the numerical correctness of this lowering.
52131bf
to
de3bfca
Compare
@vivekkhandelwal1 Yeah you were right, there was mistake. I have made the changes. To explain what I'm doing, this is the example from https://onnx.ai/onnx/operators/onnx__CumSum.html#summary
For the For the exclusive: reverse: exclusive + reverse: |
a3e29b5
to
408ea19
Compare
52d3768
to
db292ec
Compare
No description provided.