Implement lowering of torch.aten.renorm #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaneTrifa
force-pushed
the
torch-aten-renorm
branch
3 times, most recently
from
3b8c9ef
to
51d098a
Compare
BaneTrifa
force-pushed
the
torch-aten-renorm
branch
2 times, most recently
from
2838f84
to
a319a8f
Compare
BaneTrifa
force-pushed
the
torch-aten-renorm
branch
from
a319a8f
to
daf74e5
Compare
zjgarvey
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
This looks good to me.
Before merging, it might be good to get someone's opinion about adding verifiers, since I haven't seen one added in torch-mlir before (perhaps since any torch code which would result in a violation likely throws an error when importing in the first place).
ramiro050
reviewed
Jun 14, 2024
added 6 commits
June 15, 2024 00:23
…fferent types for p and maxnorm args
BaneTrifa
force-pushed
the
torch-aten-renorm
branch
2 times, most recently
from
7aacd9b
to
3af823c
Compare
ScottTodd
reviewed
Jul 2, 2024
| // Arragne reduce_dims tensor (vector), [0, 1, ... , dim-1, dim+1, ... , | ||
| // ndim-1] | ||
| llvm::SmallVector<Value> reduceDimsVector; | ||
| for (u_int64_t i = 0; i < ndim; i++) { |
There was a problem hiding this comment.
This does not build on MSVC. The portable type name (also used in other parts of this file) is uint64_t.
torch-mlir\lib\Dialect\Torch\Transforms\DecomposeComplexOps.cpp(2420): error C2065: 'u_int64_t': undeclared identifier
Sent a fix: #3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nod-ai/SHARK-Turbine/issues/689