[Fx Importer] fix mutation importer with non persistent buffer #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stellaraccident . I don't have permission to request review yet. I am tagging you here as you were the original author for support mutation in Exported Program. Do you mind taking a look at this change? Thanks! |
|
Thanks, yes I'll review. It might take me a bit as it takes me a minute to context switch and make sure I understand what is going on in this part. |
|
Hi @stellaraccident, a gentle reminder to review this pull request when you get a chance. Thank you! |
penguin-wwy
reviewed
Oct 30, 2024
|
Sorry - have been busy. I will review tomorrow |
stellaraccident
approved these changes
Oct 31, 2024
penguin-wwy
approved these changes
Oct 31, 2024
dixinzhou
deleted the
fix-mutation-importer-with-non-persistent-buffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-persistent buffer will not be a part of this module’s
state_dict. Hence when settingexperimental_support_mutation=Trueand have non-persistent buffer, the current fx importer will fail to retrieve a value fromstate_dictand producetorch.constant.noneto represent the buffer. This fix get value of non-persistent buffer from the module'sconstants.