Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onnx.If lowering with scalar condition tensor #3846

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix onnx.If lowering with scalar condition tensor #3846

merged 1 commit into from
Nov 1, 2024

Conversation

jinchen62
Copy link
Collaborator

zjgarvey
zjgarvey approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a simple lit test, but this is pretty self-explanatory so I'm fine if we omit it.

@jinchen62 jinchen62 merged commit 032a636 into llvm:main Nov 1, 2024
3 checks passed
@jinchen62 jinchen62 deleted the if_cond branch November 1, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

@AmosLewis AmosLewis Awaiting requested review from AmosLewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onnx.If errors when the two branches yield with different shapes
2 participants
@jinchen62 @zjgarvey