Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AffineScalarFunc hashable for Pandas, Pint and Pint-Pandas #170

Closed
wants to merge 10 commits into from
Closed

Make AffineScalarFunc hashable for Pandas, Pint and Pint-Pandas #170

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d90c541
Update core.py
MichaelTiemannOSC Jul 5, 2023
5d429fe
Implement hash invariant
MichaelTiemannOSC Jul 7, 2023
40154ce
Fix pickling (broken by last commit)
MichaelTiemannOSC Jul 8, 2023
634db47
Improve efficiency of AffineScalarFunc hash
MichaelTiemannOSC Jul 8, 2023
7cca18c
Update appveyor.yml
MichaelTiemannOSC Jul 11, 2023
af3447c
Revert "Update appveyor.yml"
MichaelTiemannOSC Jul 11, 2023
f3cb615
Replace nose with pytest
MichaelTiemannOSC Jul 11, 2023
5e40c49
Revert "Replace nose with pytest"
MichaelTiemannOSC Jul 11, 2023
cd3b7e0
Update appveyor.yml
MichaelTiemannOSC Jul 11, 2023
a2d4bb1
Update appveyor.yml
MichaelTiemannOSC Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions uncertainties/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,6 +1849,10 @@ def std_dev(self):
# Abbreviation (for formulas, etc.):
s = std_dev

def __hash__(self):
# Placeholder until we figure out how to really make these hashable
return id(self)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this satisfy the invariance x == y \Rightarrow hash(x) == hash(y)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some tests:

u = ufloat(1, 2)
v = ufloat(1, 2)
w = u+u
z = w / 2

# u != v, expected
# u == z, expected
# id(u) != id(v) != id(z)

a = float(1+2)
b = float(2+1)
c = a+a
d = c/2

# a == b, expected
# a == d, expected
# b == d, expected
# id(a) != id(b) != id(d)

I'll see what I can come up with to satisfy the invariant. Thanks!


def __repr__(self):
# Not putting spaces around "+/-" helps with arrays of
# Variable, as each value with an uncertainty is a
Expand Down