Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC-1466/adds self mailer qr codes documentation #460

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

juanfriss
Copy link
Contributor

@juanfriss juanfriss commented Sep 5, 2023

Fixes GC-1466

  • Updates QR code documentation to include self mailers (apart from letters and postcards).
  • Updates pages to: Specify the pages where the QR code should be stamped in a comma separated format. Your QR code can be printed in the same position on multiple pages. For postcards, the values should either be "front", "back" (for either front or back) or "front,back" (for the QR code to be printed on both sides). For self-mailers, the values should either be "inside", "outside" (for either inside or outside) or "inside,outside" (for the QR code to be printed on both sides). For letters, the values can be specific page numbers ("1", "3"), page number ranges such as "1-3", or a comma separated combination of both ("1,3,5-7").
  • Updates position description to: Sets how a QR code is being positioned in the document. When using position 'relative', you should provide one of 'top' or 'bottom', and one of 'left' or 'right'.
  • Updates the details description: Properties that the letters in your Creative should have. Check within in order to add a QR code to your creative.

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Areas of Concern (optional)

@juanfriss juanfriss requested review from BennyKitchell and a team as code owners September 5, 2023 17:18
@juanfriss juanfriss merged commit e3a09d2 into main Sep 5, 2023
2 checks passed
@juanfriss juanfriss deleted the GC-1466/update-qr-code-docs branch September 5, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants