Fix IngressClasses example #340
Conversation
The IngressClasses summary is incorrect and the example is misleading.
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Could you please allow edits by maintainers, so I can help you with |
I already see that "Allow edits and access to secrets by maintainers" is checked. What else needs to be done to allow edits? |
Signed-off-by: Piotr Zaniewski <[email protected]>
|
I'm still not able to push my changes: ➜ git push --force-with-lease fork quick-start-explore-ingress-classes-fix
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:kmadel/vcluster-docs.git
! [remote rejected] quick-start-explore-ingress-classes-fix -> quick-start-explore-ingress-classes-fix (permission denied)
error: failed to push some refs to 'github.com:kmadel/vcluster-docs.git'This worked on another PR, double-check that settings are applied (toggle them maybe), you can also add me as collaborator to your fork. You can also fix the vale errors yourself, the comments from vale bot are in the files tab. Before you do however, please rebase the PR on main to pull the latest changes. |
|
I toggled the Allow Edits settings and added you as a contributor to my fork. |
deniseschannon
dismissed
their stale review
Didn't see the vale settings failure
|
@kmadel it worked this time, I have also ported the document to main docs. If I understand correctly, this change is for the |
The IngressClasses summary is incorrect and the example is misleading.