feat(cli): implement platform destroy command #2261
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rohantmp
force-pushed
the
destroyCommand
branch
5 times, most recently
from
474e568
to
fa9d5e1
Compare
Signed-off-by: Rohan CJ <[email protected]>
rohantmp
force-pushed
the
destroyCommand
branch
from
fa9d5e1
to
4b4293b
Compare
| @@ -141,7 +161,7 @@ func (l *LoftStarter) prepare() error { | |||
| contextToLoad = l.Context | |||
| } else if platformConfig.LastInstallContext != "" && platformConfig.LastInstallContext != contextToLoad { | |||
| contextToLoad, err = l.Log.Question(&survey.QuestionOptions{ | |||
| Question: product.Replace("Seems like you try to use 'loft start' with a different kubernetes context than before. Please choose which kubernetes context you want to use"), | |||
| Question: product.Replace(fmt.Sprintf("Seems like you try to use 'loft %s' with a different kubernetes context than before. Please choose which kubernetes context you want to use", l.CommandName)), | |||
There was a problem hiding this comment.
Can we also rename the command from 'loft %s' to 'vcluster platform %s' here?
| }, | ||
| } | ||
|
|
||
| startCmd := &cobra.Command{ |
There was a problem hiding this comment.
I guess you meant destroyCmd 😉
|
|
||
| startCmd.Flags().StringVar(&cmd.Context, "context", "", "The kube context to use for installation") | ||
| startCmd.Flags().StringVar(&cmd.Namespace, "namespace", "", "The namespace vCluster platform is installed in") | ||
| startCmd.Flags().BoolVar(&cmd.DeleteNamespace, "delete-namespace", true, "Whether to delete the namespace or not") |
There was a problem hiding this comment.
Feel free to ignore: Might be handy to have something like --ignore-not-found, which does not error when there's no platfrom.
| @@ -0,0 +1,248 @@ | |||
| package start | |||
There was a problem hiding this comment.
I guess this should be in a destroy package!?
There was a problem hiding this comment.
yeah, makes sense! I can put the client initializers and validation in the clihelper
| ) | ||
|
|
||
| // define the order of resource deletion | ||
| var resourceOrder = []string{ |
There was a problem hiding this comment.
Just stating the obvious, but this means we always have to keep the resources in sync manually here because we have to respect the ordering!?
Do you know what would happen if we would just delete all resources coming from discoveryClient.ServerResourcesForGroupVersion("storage.loft.sh/v1") with a Background deletion policy without a specific order?!
There was a problem hiding this comment.
Yeah, I think we need to do some e2e where we run vclusterctl commands against a platform instance.
I think the deletion would hang in most cases if we did an unordered delete because many things like accesskeys don't have finalizers
|
I'll move it into a destroy folder and move some of the common options out into clihelper |
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-3980
Please provide a short message that should be published in the vcluster release notes
Add a new cli command: vcluster platform destroy
What else do we need to know?
The command will wait for each resource type to finish cleaning up before proceeding to the next, so that resource types that depend on each other will not prevent cleanup. (Remove a cluster object before a virtualclusterinstance running on it, etc)
vcluster platform destroy(no args) on v4.0.0:vcluster platform destroy(no args) on v3.4.9: