DRAFT added support for centiseconds in the TimeElementsWithFractionOfSeconds #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 96.20% 96.67% +0.47%
==========================================
Files 24 24
Lines 2343 2375 +32
==========================================
+ Hits 2254 2296 +42
+ Misses 89 79 -10 ☔ View full report in Codecov by Sentry. |
joachimmetz
reviewed
Apr 14, 2024
joachimmetz
reviewed
Apr 14, 2024
tests/time_elements.py
Outdated
|
|
||
| expected_time_elements_tuple = (2010, 8, 12, 20, 6, 31) | ||
| time_elements_object = time_elements.TimeElementsWithFractionOfSecond( | ||
| fraction_of_second=decimal.Decimal(0.8742), |
There was a problem hiding this comment.
style nit: 4 space continuation indentation.
|
@rick-slin thanks, the changes look good to me. Left a small nit and a question. |
added 3 commits
May 4, 2024 06:15
…ionOfSeconds added tests for TimeElementsWithFractionOfSeconds class
joachimmetz
reviewed
May 4, 2024
dfdatetime/precisions.py
Outdated
|
|
||
| Returns: | ||
| decimal.Decimal: fraction of second, which must be a value between 0.00 | ||
| and 1.00. |
There was a problem hiding this comment.
style nit: missing continuation indentation
joachimmetz
reviewed
May 4, 2024
dfdatetime/precisions.py
Outdated
| nanoseconds (int): number of nanoseconds. | ||
|
|
||
| Returns: | ||
| decimal.Decimal: fraction of second, which must be a value between 0.00 |
There was a problem hiding this comment.
no need for the addition 0 in 0.00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joachimmetz As discussed in the plaso PR #4688, I would like to propose these change to add support for centisecond precision in TimeElementsWithFractionOfSeconds.
I think it would be easy to add 100us precision based on that template.
Thank you for your time and consideration.