Skip to content

Commit

Permalink
Do not force raw access depending on platform (#905)
Browse files Browse the repository at this point in the history
* Do not force raw access depending on platform

* Fix test
  • Loading branch information
tomchop authored Aug 15, 2024
1 parent ed7ea68 commit eedbc3d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions dftimewolf/lib/collectors/grr_hosts.py
Original file line number Diff line number Diff line change
Expand Up @@ -858,10 +858,6 @@ def Process(self, container: containers.Host
if not artifact_list:
return

if client.data.os_info.system.lower() == 'windows':
self.logger.debug("Switching to raw filesystem access for Windows.")
self.use_raw_filesystem_access = True

flow_args = flows_pb2.ArtifactCollectorFlowArgs(
artifact_list=artifact_list,
use_raw_filesystem_access=self.use_raw_filesystem_access,
Expand Down
3 changes: 1 addition & 2 deletions tests/lib/collectors/grr_hosts.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,7 @@ def testProcessWindowsArtifacts(self,
self.grr_artifact_collector.PostProcess()

kwargs = mock_ArtifactCollectorFlowArgs.call_args[1]
# Raw access for Windows
self.assertTrue(kwargs['use_raw_filesystem_access'])
self.assertFalse(kwargs["use_raw_filesystem_access"])

@mock.patch('grr_api_client.api.InitHttp')
@mock.patch('grr_api_client.flow.FlowRef.Get')
Expand Down

0 comments on commit eedbc3d

Please sign in to comment.