Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More options for Timesketch auth (user/pass) #794

Merged
merged 22 commits into from
Oct 25, 2023
Merged

More options for Timesketch auth (user/pass) #794

merged 22 commits into from
Oct 25, 2023

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Oct 24, 2023 •
edited
Loading

  • Changes in the Timesketch exporter and enhancer (and recipes) with the option of using simple user / pass authentication

@tomchop tomchop changed the title Docker Recipe changes for Timesketch + docker changes Oct 24, 2023
@tomchop tomchop changed the title Recipe changes for Timesketch + docker changes More options for Timesketch auth (user/pass) Oct 24, 2023
@tomchop tomchop marked this pull request as ready for review October 24, 2023 16:16
jleaniz
jleaniz previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a couple comments.

data/recipes/workspace_user_login_ts.json Outdated Show resolved Hide resolved
dftimewolf/lib/exporters/timesketch.py Show resolved Hide resolved
@tomchop
Copy link
Collaborator Author

tomchop commented Oct 25, 2023

merging as @jleaniz already approved

@tomchop tomchop merged commit ee140e7 into log2timeline:main Oct 25, 2023
9 checks passed
@tomchop tomchop deleted the docker branch October 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz left review comments

@ramo-j ramo-j Awaiting requested review from ramo-j

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchop @jleaniz