Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update TS types files for better TS support #10

Merged
merged 1 commit into from
May 19, 2021

Conversation

TerryMooreII
Copy link
Collaborator

This will fix the typescript issues reported in issue #7

Semver: patch

Copy link
Contributor

@michaelshi-logdna michaelshi-logdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) as mentioned over Slack - it looks like we have UMD support regression unrelated to this change in 1.1 (not that it was really officially documented anyways), but we'll fix it in another PR

@TerryMooreII
Copy link
Collaborator Author

lgtm :) as mentioned over Slack - it looks like we have UMD support regression unrelated to this change in 1.1 (not that it was really officially documented anyways), but we'll fix it in another PR

this is now fixed

@TerryMooreII TerryMooreII reopened this May 18, 2021
@TerryMooreII TerryMooreII merged commit 8e2a5aa into main May 19, 2021
@TerryMooreII TerryMooreII deleted the tm/rollup-ts-errors branch May 19, 2021 14:15
@logdnabot
Copy link
Member

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants