Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TypeScript Types, Minor Code Housekeeping #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prescience-data
Copy link

Implements:

  • Fixes TypeScript exports
  • Consolidates dangling types
  • Adds typed Exceptions
  • Inlines some verbose code
  • Adds lint to npm commands

Suggestions:

  • Would be good to implement some ESLint rules to avoid contributors IDEs messing with code style (some things that prettier doesn't catch).
  • With typed Exceptions added, may be worth adding specific error instanceof checks in certain places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant