-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HWORKS-927] Support canary serving deployments #1102
base: master
Are you sure you want to change the base?
Conversation
793208c
to
03d380c
Compare
1424a37
to
a6455f3
Compare
`model_name` varchar(255) COLLATE latin1_general_cs NOT NULL, | ||
`model_version` int(11) NOT NULL, | ||
`model_framework` int(11) NOT NULL, | ||
`deployed` timestamp DEFAULT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deployed
field is already in line 1275. No need to add it here.
`lock_ip` varchar(15) COLLATE latin1_general_cs DEFAULT NULL, | ||
`lock_timestamp` bigint(20) DEFAULT NULL, | ||
`serving_tool` int(11) NOT NULL DEFAULT '0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serving_tool
is already in line 1274. No need to add it here.
CONSTRAINT unique_specification UNIQUE (specification), | ||
CONSTRAINT unique_canary_spec UNIQUE (canary_spec), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the missing quotes in the constraint names and the column names?
@@ -1287,7 +1279,37 @@ CREATE TABLE `serving` ( | |||
CONSTRAINT `user_fk_serving` FOREIGN KEY (`creator`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION, | |||
CONSTRAINT `deployed_by_fk_serving` FOREIGN KEY (`deployed_by`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION, | |||
CONSTRAINT `kafka_fk` FOREIGN KEY (`kafka_topic_id`) REFERENCES `project_topics` (`id`) ON DELETE SET NULL ON UPDATE NO ACTION, | |||
CONSTRAINT `FK_284_315` FOREIGN KEY (`project_id`) REFERENCES `project` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this constraint removed?
`serving_tool` int(11) NOT NULL DEFAULT '0', | ||
`specification` int(11) NOT NULL, | ||
`canary_spec` int(11) DEFAULT NULL, | ||
`canary_traffic_percentage` TINYINT DEFAULT NULL, | ||
`kafka_topic_id` int(11) DEFAULT NULL, | ||
`inference_logging` int(11) DEFAULT NULL, | ||
`model_server` int(11) NOT NULL DEFAULT '0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
model_server
is on the serving_spec
table. We should remove it from here.
`serving_tool` int(11) NOT NULL DEFAULT '0', | ||
`specification` int(11) NOT NULL, | ||
`canary_spec` int(11) DEFAULT NULL, | ||
`canary_traffic_percentage` TINYINT DEFAULT NULL, | ||
`kafka_topic_id` int(11) DEFAULT NULL, | ||
`inference_logging` int(11) DEFAULT NULL, | ||
`model_server` int(11) NOT NULL DEFAULT '0', | ||
`serving_tool` int(11) NOT NULL DEFAULT '0', | ||
`deployed` timestamp DEFAULT NULL, | ||
`deployed_by` int(11) DEFAULT NULL, | ||
`revision` varchar(8) DEFAULT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revision
is on the serving_spec
table. We should remove it from here also
@@ -45,3 +45,49 @@ ALTER TABLE `hopsworks`.`feature_store_jdbc_connector` | |||
ALTER TABLE `hopsworks`.`serving` ADD COLUMN `deployed_by` int(11) DEFAULT NULL; | |||
ALTER TABLE `hopsworks`.`serving` ADD KEY `deployed_by_fk` (`deployed_by`); | |||
ALTER TABLE `hopsworks`.`serving` ADD CONSTRAINT `deployed_by_fk_serving` FOREIGN KEY (`deployed_by`) REFERENCES `users` (`uid`) ON DELETE CASCADE ON UPDATE NO ACTION; | |||
|
|||
-- HWORKS-927 | |||
ALTER TABLE `hopsworks`.`serving` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also drop revision
No description provided.