Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci.yml changes and some tests #10

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Conversation

AdrickTench
Copy link
Contributor

No description provided.

@TeamSPoon
Copy link
Member

TeamSPoon commented Dec 13, 2024

image
The screenshot here looks like it the pull request is adding conflicts ">>>>>>>>>>>>>>>>>>>>>"
cause by a failed merge

then this change....

image
looks like it would try to run tests in other places like trueagi-io/metta-wam if it was non-scheduled .. but we want to prevent that...

The pull request is likely more about tests you are tryign to add.. so i suggest syncing uip and then adding the tests

@AdrickTench
Copy link
Contributor Author

Not sure how the merge conflicts are there, I'll fix those. The != schedule clause is there so that people's forks run commit tests but not the nightly tests. metta-wam should have its own ci.yml version independent of these changes.

@TeamSPoon
Copy link
Member

I agree with the forks running the command on push requests ..

I wonder if the fact "${cmd[@]}" was all in quotes was why it didnt work

@TeamSPoon TeamSPoon merged commit 8cd9211 into logicmoo:master Dec 13, 2024
1 check failed
@AdrickTench
Copy link
Contributor Author

I tried removing the quotes and it didn't work properly, likewise using * instead of @

AdrickTench pushed a commit to AdrickTench/metta-testsuite that referenced this pull request Dec 19, 2024
jazzbox35 pushed a commit to jazzbox35/metta-testsuite that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants