-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VST support for macOS. #70
base: master
Are you sure you want to change the base?
Conversation
Redefinition of _WIN32_WINNT to 0x0600 is required is vstgui.h (line 69).
Surprisingly /D compiler option takes precedence over #define and windows vista features are found.
The /D switch worked because I was compiling with a vstgui.h already patched. So no surprise. Because I can not see any workaround but patching vstgui.cpp and vstgui.h, a patch is included and AppVeyor script is modified to apply the patch.
…cache save. VSTSDK download is failing by some reason just for the Visual Studio 2013 + x64 job. and it makes an unsuccessful build, so cache is not created. Let's try to get success by removing that job and put in it again in next commit.
So, I was able to make AppVeyor to build successfully the project for Win32 and x64 by patching the vstsdk source code, for requiring Windows Vista features. But wait; is AppVeyor's cache shared among branches? I hope no, because it could affect master branch compilation. |
So, I realized that AppVeyor can also build macOS stuff. So added macOS image to .appveyor.yml and It build the project successfully for that platform. But there is a caveat: downloading vstsdk always fails for one of the two windows jobs; that Invoke-WebRequest cmdlet. I tried to reuse the cache, but no success. |
Finally getting a chance to look at this, and first off, let me say this is great work, and I'm super pleased to see it! We've been wanting to build mac versions of the plugs in particular for a long time - ideally this would open the door for many more musicians to use the tool than can today, as you're surely aware. Looking at most of the changes, things look pretty benign/straightforward, but I had some thoughts:
|
re the Invoke-WebRequest cmdlet for Windows builds, I too noticed that this was a bit flaky - however, you can use the "re-run incomplete" button in the appveyor UI to restart the failing/incomplete build jobs (this also works if you notice a particular job failing early in the run and cancel the build). It's ofc annoying that it's so flaky, but it should still work. |
Support for macOS. Just the VST stuff.
Checked on the environment described in macOS support
Details about the modifications are documentes in [macOS porting details] wiki page.(https://github.com/fefal64/WaveSabre/wiki/macOS-porting-details) wiki page.
Fixed windows compilation but requires editing
vstgui.h
.