Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PSP34 token validation #195

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Improve PSP34 token validation #195

merged 1 commit into from
Oct 13, 2023

Conversation

gdethier
Copy link
Contributor

  • Token with ID 0 was wrongly detected as invalid.
  • Some schema validation was missing for ID object.

benoitdevos
benoitdevos approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

packages/client/package.json Outdated Show resolved Hide resolved
@gdethier gdethier force-pushed the feature/fix-psp34-token-validation branch from 296ddad to 928813a Compare October 13, 2023 09:49
@gdethier gdethier merged commit 8c03bee into main Oct 13, 2023
1 check passed
@gdethier gdethier deleted the feature/fix-psp34-token-validation branch October 13, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos