Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt node-api to recurrent fees. #206

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Adapt node-api to recurrent fees. #206

merged 5 commits into from
Nov 7, 2023

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Nov 6, 2023 •
edited
Loading

Recurrent Fees node-api

logion-network/logion-internal#1051

Package client-node

  • Fix README.md
  • Integration tests: add lost IPFS config, fix test.

logion-network/logion-internal#1046

@benoitdevos benoitdevos marked this pull request as ready for review November 6, 2023 18:17
gdethier
gdethier approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and thanks for fixing the integration tests. I think you forgot to update the definitions.ts file.

@benoitdevos benoitdevos merged commit 34801fd into main Nov 7, 2023
1 check passed
@benoitdevos benoitdevos deleted the feature/recurrent-fees branch November 7, 2023 07:40
@gdethier gdethier mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier