Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decentralized directory. #271

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Decentralized directory. #271

merged 2 commits into from
Jun 18, 2024

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Jun 18, 2024 •
edited
Loading

Companion of logion-network/logion-backend-ts#311

  • For the directory service, connect to LLO's backend instead of directory.
  • Perform the "multiplexing" (i.e. the consolidation of data from all backends).
  • Adapt tests accordingly: Same 3 legal officers, Charlie being the guest of Alice. Extra backend and directory are removed.

logion-network/logion-internal#1292

gdethier
gdethier requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I would rename DirectoryClient class and variables. Also, the authentication token is not passed to LegalOfficerClass instance in DirectoryClient, which would break fetching configuration using the instance.

packages/client-node/integration/LegalOfficer.ts Outdated Show resolved Hide resolved
packages/client/src/DirectoryClient.ts Outdated Show resolved Hide resolved
packages/client/src/DirectoryClient.ts Outdated Show resolved Hide resolved
gdethier
gdethier approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoitdevos benoitdevos merged commit 8db2726 into main Jun 18, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/decentralize-dir branch June 18, 2024 13:42
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier