Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate size setting #85

Open
jordansissel opened this issue Nov 18, 2017 · 3 comments
Open

Deprecate size setting #85

jordansissel opened this issue Nov 18, 2017 · 3 comments

Comments

@jordansissel
Copy link
Contributor

jordansissel commented Nov 18, 2017

The size setting is how many records are returned per scroll request, and it can easily be confused with "how many records to return, period" which is not what it does.

In practice, users should not care about this setting, and I find no reason why a user would want to set it.

The default (1000) is probably fine for every use case.

@ctindel
Copy link

ctindel commented Nov 18, 2017

@jordansissel do you think users should need to change any of the scroll settings? Or is the use case always "process every record returned by the query no matter how long it takes"? For example I always use 60000m in mine.

@jordansissel
Copy link
Contributor Author

jordansissel commented Nov 18, 2017 via email

@SyedShahzaib790
Copy link

Hi,
Can someone tell me, whats the valid parameter to use in order to get specific number of records i.e. 10 records only. As it is mentioned above, one can confuse this size parameter. I am one of the victim :p
Can please specify which parameter/attribute to use to get specific number of records instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants