Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hosts => "es_host:port" regression #168

Merged
merged 9 commits into from
Feb 21, 2022

Conversation

kares
Copy link
Contributor

@kares kares commented Feb 17, 2022

Same as: logstash-plugins/logstash-filter-elasticsearch#156

The change here makes sure "es_host:port" is properly split into a { host: es_host, port: port } pair.
Elasticsearch gem not seeing a port: key will add the port: 9200 default and Manticore 0.8 appends the port part while building the URL.

The fix is demonstrated by the SECURE_INTEGRATION=true targets :

Also added some explicit CI targets against Manticore 0.7.1 which has been dominant through 7.x line.


Unfortunately specs are 🔴 on CI due various issues:

@kares kares changed the title Test: reproduce double :port info from ES client Fix: hosts => "es_host:port" regression Feb 17, 2022
@kares kares linked an issue Feb 17, 2022 that may be closed by this pull request
@kares kares marked this pull request as ready for review February 17, 2022 11:42
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 8385b2e into logstash-plugins:main Feb 21, 2022
kares added a commit to kares/logstash-input-elasticsearch that referenced this pull request Mar 14, 2022
* main:
  Fix: hosts => "es_host:port" regression (logstash-plugins#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression on Manticore 0.8.0 due port being part of host
3 participants