allow a user to configure the emulator as a google pubsub endpoint fo… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test name Co-Authored-By: JosephGaiser <[email protected]>
|
Any thoughts on this? We are running off of a forked version right now, and would like to be able to clean up that fork. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r testing
We are building out a logstash transformation process and would love to be able to run integration tests against it locally using the google cloud pubsub emulator.
Here's a first pass at allowing the emulator configuration so we can get the conversation started. I've used the locally built gem to prove that things are working as you'd expect against a real emulator, and run a transformation process on it. I'd definitely like your feedback on how you'd like the config properties to work (and how they should be named).
I'm by no means a ruby pro, but because of how jruby loads java classes (doesn't load io package), I at least felt it was important to prove that we can create a client pointed at an emulator url in the client tests.
Thanks for taking a look!