Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #155 : Fixed the delay while moving up the top bar #156

Merged
merged 1 commit into from
May 16, 2017

Conversation

kavithaenair
Copy link
Member

@kavithaenair kavithaenair commented May 12, 2017

Short description

Fixes #155
Related to issue #77 and PR #142

Changes:
Demo link : https://kavithaenair.github.io/

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@kavithaenair
Copy link
Member Author

@djmgit @daminisatya open for review

Copy link
Member

@djmgit djmgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This speeds up the hiding animation no doubt although delay is still there.However it looks good to me.
@mariobehling Just a doubt.I guess the original issue which brought in this change is this #77 The desired effect was that of google play store which we do not have yet.Presently apps.loklak.org has got a different scrolling effect which is different from that of playstore. So should we make this effect final or is issue #77 still valid?

@mariobehling
Copy link
Member

@djmgit I think it is good enough for now and we can come back to this later, if we want it even closer to Google.

@mariobehling mariobehling merged commit cfa1bfb into loklak:master May 16, 2017
@kavithaenair kavithaenair deleted the ScrollSpeedUp branch May 16, 2017 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants