Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #181 - integrated store listing page with main app page #184

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

djmgit
Copy link
Member

@djmgit djmgit commented Jun 13, 2017

fixes issue #181. Now on clicking the apps on main page
the store listing page will be loaded.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

fixes issue loklak#181. Now on clicking the apps on main page
the store listing page will be loaded.
@djmgit
Copy link
Member Author

djmgit commented Jun 13, 2017

Test link : http://loklakapps.surge.sh/
Select whatsTrending app (the last one)

The store listing page will be shown properly for majority of the other apps once PR: #178 is merged.

@kavithaenair @Achint08 @SKrPl open for review

Copy link
Member

@daminisatya daminisatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djmgit Resolve the requested changes for the PR #178 and it's good to go. I can see the changes.

@mariobehling mariobehling merged commit d05a944 into loklak:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants