Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Longhorn toolbox CLI #14
feat: Longhorn toolbox CLI #14
Changes from all commits
61beba6
16c9436
d1e9831
1eb1038
e76a4db
7e34ea1
f4791c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: tried to undertand the longhornctl-local and longhornctl. The naming is a bit confusing. We can find better names later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is iSCS and NFS client? I would recommend highlighting them and make them by default.
In the future, probably can exclusively enable one of them.
EnableSPDK need to depend on if HugePageSize is set as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both will be checked, there is no option to enable or disable them individually. The results will be outputted in detail.
I think the output is clear enough to indicate whether the individual items meet the requirement. Adding extra options might complicate the process for users. Is there any benefit to having separate flags for enabling the checking of iSCSI and NFS client?
The flags have been carried over from the current implementation. I don't have much experience with the v2 engine dependency check, so I suggest enhancing it in a separate PR specific to the v2 engine. @derekbit @innobead , what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIO instead of UIO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#14 (comment)