Fix bug the engine might choose a replica with a smaller head size to be

the source of truth for auto-salvage longhorn-8659 longhorn-8563 Signed-off-by: Phan Le <[email protected]>
longhorn · May 28, 2024 · 6419b70 · 6419b70
1 parent e39b7f0
commit 6419b70
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/controller/control.go b/pkg/controller/control.go
@@ -646,8 +646,9 @@ func (c *Controller) salvageRevisionCounterDisabledReplicas() error {
 		// Any replica within 5 seconds before lastModifyTime
 		// can be good replica.
 		if t.Add(lastModifyCheckPeriod).After(lastTime) {
-			if salvageReplica.HeadFileSize >= largestSize {
+			if salvageReplica.HeadFileSize > largestSize {
 				bestCandidate = r
+				largestSize = salvageReplica.HeadFileSize
 			}
 		}
 	}