feat(auto-balance): disk in pressure #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
shuo-wu
previously approved these changes
Feb 5, 2024
Comment on lines
+38
to
+42
| cli.BoolFlag{ | ||
| Name: "sync-local", | ||
| Required: false, | ||
| Usage: "sync local replica", | ||
| }, |
There was a problem hiding this comment.
NIT: Do we need this if we won't implement local sync for this debug cmdline?
proto/ptypes/syncagent.proto
Outdated
| @@ -65,6 +65,12 @@ message FilesSyncRequest { | |||
| repeated SyncFileInfo sync_file_info_list = 3; | |||
| bool fast_sync = 4; | |||
| int32 file_sync_http_client_timeout = 5; | |||
| FileLocalSync local_sync = 6; | |||
There was a problem hiding this comment.
NIT: I am thinking we can reuse the existing fields from_address and to_host for local sync. But a boolean field is required instead. I am fine with the current implementation anyway.
|
Need to wait #1015. cc @FrankYang0529 |
|
This pull request is now in conflict. Could you fix it @c3y1huang? 🙏 |
1 similar comment
|
This pull request is now in conflict. Could you fix it @c3y1huang? 🙏 |
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
9 times, most recently
from
285c0e1
to
e22874a
Compare
|
This pull request is now in conflict. Could you fix it @c3y1huang? 🙏 |
derekbit
reviewed
Jun 30, 2024
derekbit
reviewed
Jun 30, 2024
derekbit
reviewed
Jun 30, 2024
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
e22874a
to
e540686
Compare
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
2 times, most recently
from
1e3e0d9
to
e93dd8d
Compare
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
5 times, most recently
from
f5ee325
to
b482101
Compare
|
@c3y1huang Is it ready? |
longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
b482101
to
a7dc671
Compare
|
@derekbit , this is ready for review. |
derekbit
reviewed
Jul 3, 2024
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
a7dc671
to
1c150ab
Compare
derekbit
reviewed
Jul 4, 2024
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
1c150ab
to
e3ec778
Compare
longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
e3ec778
to
828da65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#4105
What this PR does / why we need it:
Introduce file local sync to copy the file when there is another running replica on the same node so the data transfer doesn't need to go through TCP.
Special notes for your reviewer:
NoneAdditional documentation or context
None