Fix bug the engine might choose a replica with a smaller head size to be the source of truth for auto-salvage (backport #1114) #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
the source of truth for auto-salvage longhorn-8659 Signed-off-by: Phan Le <[email protected]> (cherry picked from commit fd668c9)
The old logic is that: 1. Filter replica candidates to keep only replicas which was modified within the last 5 seconds from the last modified replica 2. Then filter to keep only replicas with head size equals to the biggest one 3. Then pick a random replica from the set The new logic: 1. Filter replica candiates to keep only replicas which was modified within the last 5 seconds from the last modified replica 2. Then filter to keep only replicas with head size equal to the biggest one 3. Then pick the last modified replica from the set longhorn-8659 longhorn-8563 Signed-off-by: Phan Le <[email protected]> (cherry picked from commit 15c1e89)
innobead
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details are in the issue description of longhorn/longhorn#8659
This is an automatic backport of pull request #1114 done by [Mergify](https://mergify.com).