feat(docker-volume): remove volume from dockerfile, no compliant with CIS benchmark #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CIS benchmark Signed-off-by: lenglet-k <[email protected]>
innobead
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue#8780
What this PR does / why we need it:
This remove volume /usr/local/bin define in dockerfile. In my case, longhorn-engine gets the permission denied error because the noexec option is propagated to the container automatically. in fact, my /var/ volume, used by containerd, has
noexecoption, with this option longhorn-manager is not allow to start because this option not allow the execution of executable binaries in the mounted filesystemSpecial notes for your reviewer:
is this volume really used ?
Additional documentation or context