fix(node-controller): delete instance manager and requeue node when l…

…abels are missing longhorn/longhorn-9464 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn · Sep 16, 2024 · 86a4416 · 86a4416
1 parent 3eb0636
commit 86a4416
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/controller/node_controller.go b/controller/node_controller.go
@@ -1238,7 +1238,17 @@ func (nc *NodeController) syncInstanceManagers(node *longhorn.Node) error {
 				}
 
 				log.Infof("Creating default instance manager %v, image: %v, dataEngine: %v", imName, defaultInstanceManagerImage, dataEngine)
-				if _, err := nc.createInstanceManager(node, imName, defaultInstanceManagerImage, imType, dataEngine); err != nil {
+				_, err = nc.createInstanceManager(node, imName, defaultInstanceManagerImage, imType, dataEngine)
+				if err != nil {
+					if apierrors.IsAlreadyExists(err) {
+						log.WithError(err).Warnf("Deleting instance manager %v because it cannot be obtained by selector labels", imName)
+						if err := nc.ds.DeleteInstanceManager(imName); err != nil {
+							return err
+						}
+
+						nc.enqueueNode(node)
+						return nil
+					}
 					return err
 				}
 			}