Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): add and modify node.Status.Conditions #3065

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mantissahz
Copy link
Contributor

@mantissahz mantissahz commented Aug 13, 2024

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#9153

What this PR does / why we need it:

Add the node.Status.Condition ModulesLoaded and check if the module dm_crypt is enabled.

Special notes for your reviewer:

Additional documentation or context

@mantissahz mantissahz requested a review from derekbit August 22, 2024 00:52
@mantissahz mantissahz force-pushed the issue9153 branch 4 times, most recently from 9bf320b to 8d84685 Compare August 26, 2024 14:33
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
@mantissahz mantissahz force-pushed the issue9153 branch 2 times, most recently from b207776 to 13a2fd7 Compare September 6, 2024 07:46
@mantissahz mantissahz requested a review from derekbit September 6, 2024 07:47
@mantissahz mantissahz force-pushed the issue9153 branch 4 times, most recently from 79236cb to 8b1028e Compare September 10, 2024 01:48
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM, but need to fix the parse function for the the config file and add a unit test cases for the newly introduced functions.

k8s/pkg/apis/longhorn/v1beta2/node.go Outdated Show resolved Hide resolved
k8s/pkg/apis/longhorn/v1beta2/node.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
Check if the module `dm_crypt` is enabled as the first module.
Add a unit test to check the kernel modules condition.

ref: longhorn/longhorn 9153

Signed-off-by: James Lu <[email protected]>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the effort.

@derekbit derekbit merged commit 6370a24 into longhorn:master Sep 27, 2024
8 checks passed
@mantissahz
Copy link
Contributor Author

@Mergifyio backport v1.7.x

Copy link

mergify bot commented Sep 27, 2024

backport v1.7.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants