feat(auto-salvage): v2 support #222
Open
+1,466
−1,103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
2 times, most recently
from
4acf3c9
to
0d205b4
Compare
|
This pull request is now in conflict. Could you fix it @c3y1huang? 🙏 |
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
4 times, most recently
from
b411222
to
80dd23b
Compare
c3y1huang
commented
Sep 27, 2024
go.mod
Outdated
Comment on lines
7
to
9
| replace github.com/longhorn/types => github.com/c3y1huang/types v0.0.0-20240927004343-3ad221f0cbfc | ||
|
|
||
| replace github.com/longhorn/go-common-libs => github.com/c3y1huang/go-common-libs v0.0.0-20240927004544-ee33d7bb917c |
There was a problem hiding this comment.
TODO: update when dependency PRs are merged.
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
95e1ee9
to
c653fcf
Compare
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
c653fcf
to
743f3f2
Compare
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
743f3f2
to
1ad077c
Compare
DamiaSan
reviewed
Sep 27, 2024
| } | ||
|
|
||
| for replicaName := range e.ReplicaAddressMap { | ||
| if _, exist := salvageCandidates[replicaName]; !exist { |
There was a problem hiding this comment.
How can replicaName not exist in salvageCandidates? This map has been populated by volumeHeadSizeToReplicaNames, which has been populated by ReplicaAddressMap.
|
This pull request is now in conflict. Could you fix it @c3y1huang? 🙏 |
shuo-wu
reviewed
Oct 14, 2024
| @@ -206,7 +207,15 @@ func (e *Engine) Create(spdkClient *spdkclient.Client, replicaAddressMap map[str | |||
| e.ReplicaAddressMap = replicaAddressMap | |||
| e.log = e.log.WithField("replicaAddressMap", replicaAddressMap) | |||
|
|
|||
| e.checkAndUpdateInfoFromReplicaNoLock() | |||
| if salvageRequested { | |||
There was a problem hiding this comment.
Does the engine need to try to connect all replicas before a salvage?
If NO, then the mode check inside updateInfoToFilterReplicaSalvageCandidates makes no sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8430
What this PR does / why we need it:
Skip creating lvol bdev for a new replica instance if it exists.
Special notes for your reviewer:
NoneAdditional documentation or context
None