Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method for mode discovery #2201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Mar 3, 2024

This PR and the related PRs at loopback-connector & loopback-connector-mysql will enable cli's discoverer to add properties and their options based on the database's strict mode.

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Mar 3, 2024

Pull Request Test Coverage Report for Build 8599495495

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 84.727%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/datasource.js 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
lib/datasource.js 5 72.29%
Totals Coverage Status
Change from base Build 8594443975: -0.04%
Covered Lines: 7279
Relevant Lines: 8283

💛 - Coveralls

@aaqilniz aaqilniz force-pushed the feat/strict-mode branch 2 times, most recently from 51066c4 to 13bf61a Compare March 9, 2024 15:43
@aaqilniz aaqilniz marked this pull request as ready for review April 13, 2024 17:03
@aaqilniz aaqilniz requested a review from dhmlau as a code owner April 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants