fix: a #123 style has that wasn't a valid PR was causing a fatal error

loopwerk · Aug 17, 2021 · 6730d9b · 6730d9b
1 parent b31b782
commit 6730d9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -7166,8 +7166,13 @@ async function parseCommitMessage(message, repoUrl, fetchUserFunc) {
   const found = cAst.subject.match(PR_REGEX);
   if (found) {
     const pullNumber = found[1];
-    const { username, userUrl } = await fetchUserFunc(pullNumber);
-    cAst.subject = cAst.subject.replace(PR_REGEX, () => `[#${pullNumber}](${repoUrl}/pull/${pullNumber}) by [${username}](${userUrl})`);
+
+    try {
+      const { username, userUrl } = await fetchUserFunc(pullNumber);
+      cAst.subject = cAst.subject.replace(PR_REGEX, () => `[#${pullNumber}](${repoUrl}/pull/${pullNumber}) by [${username}](${userUrl})`);
+    } catch (error) {
+      // We found a #123 style hash, but it wasn't a valid PR. Ignore.
+    }
   }
 
   return cAst;

diff --git a/src/parseCommitMessage.js b/src/parseCommitMessage.js
@@ -19,8 +19,13 @@ async function parseCommitMessage(message, repoUrl, fetchUserFunc) {
   const found = cAst.subject.match(PR_REGEX);
   if (found) {
     const pullNumber = found[1];
-    const { username, userUrl } = await fetchUserFunc(pullNumber);
-    cAst.subject = cAst.subject.replace(PR_REGEX, () => `[#${pullNumber}](${repoUrl}/pull/${pullNumber}) by [${username}](${userUrl})`);
+
+    try {
+      const { username, userUrl } = await fetchUserFunc(pullNumber);
+      cAst.subject = cAst.subject.replace(PR_REGEX, () => `[#${pullNumber}](${repoUrl}/pull/${pullNumber}) by [${username}](${userUrl})`);
+    } catch (error) {
+      // We found a #123 style hash, but it wasn't a valid PR. Ignore.
+    }
   }
 
   return cAst;