Added RootDirectory option to Zip task #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this different from WorkingDirectory? |
|
This pull request adds a feature which lets you specify a root directory that you want the archived files to be placed within, inside the generated zip file. ExampleUser has two files to archive: <RootDir>C:\Foo</RootDir>
<MyFiles
Include="$(RootDir)\Bar.txt;$(RootDir)\Baz.txt" />Case 1: Without RootDirectory<Zip
ZipFileName="Qux.zip"
Files="@(MyFiles)"
WorkingDirectory="$(RootDir)"
ZipLevel="9" />Generated Zip File
Case 2: With RootDirectory<Zip
ZipFileName="Qux.zip"
Files="@(MyFiles)"
WorkingDirectory="$(RootDir)"
RootDirectory="MyCustomFolder"
ZipLevel="9" />Generated Zip File
|
|
A better name for this option might be "ArchiveFolder" vs "RootDirectory", now that I think about it. What do you think? |
arlm
added a commit
to arlm/msbuildtasks
that referenced
this pull request
Feb 15, 2017
Added RootDirectory option to Zip task loresoft#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to specify a common directory for the archive.