Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | Can't run 0.5.1 on Windows, asks for additional dlls #61

Open
ke1ne opened this issue Jul 1, 2023 · 14 comments · May be fixed by #62
Open

BUG | Can't run 0.5.1 on Windows, asks for additional dlls #61

ke1ne opened this issue Jul 1, 2023 · 14 comments · May be fixed by #62
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ke1ne
Copy link

ke1ne commented Jul 1, 2023

Hi, the latest version 0.5.1 on Windows asks for additional dlls: cublas64_12.dll and cudart64_12.dll.
Any requirements to install manually?
Thanks!

@louisgv
Copy link
Owner

louisgv commented Jul 2, 2023

Hmmm... I wonder if these's a way to pack these with the installation, or do we have to add them as additional asset...

@louisgv
Copy link
Owner

louisgv commented Jul 2, 2023

@ke1ne you can grab those DLL from https://developer.nvidia.com/cuda-12-1-0-download-archive, but we should figure out how to bundle them

@ke1ne
Copy link
Author

ke1ne commented Jul 2, 2023

@louisgv After the CUDA Runtime installation, it didn't handle dlls until I added their directory (c:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.2\bin) to the PATH environment variable. It seems to work now, thanks!

@louisgv louisgv linked a pull request Jul 2, 2023 that will close this issue
@louisgv louisgv added enhancement New feature or request help wanted Extra attention is needed labels Jul 3, 2023
@louisgv
Copy link
Owner

louisgv commented Jul 3, 2023

@ke1ne could you help me with reproducing the build DLL in your local machine? I don't have a Windows box handy atm, and the one I have nearby doesn't have a GPU xD......

Basically we need to include the DLL into the resources specification in #62

@louisgv
Copy link
Owner

louisgv commented Jul 3, 2023

@ke1ne
Copy link
Author

ke1ne commented Jul 3, 2023

@louisgv I will try to help for sure. Please instruct me what to do and what we need to achieve.

@louisgv
Copy link
Owner

louisgv commented Jul 4, 2023

@ke1ne awesome! Can you try cloning this repo, checking out the 61-bug-cuda-dlls branch and see if you can add those dll into the build directory, compile and see if it built and run in dev mode? LMK if you need steps-by-steps instruction!

@ke1ne
Copy link
Author

ke1ne commented Jul 4, 2023

@louisgv yeap, I need some guide

@LLukas22
Copy link
Collaborator

LLukas22 commented Jul 5, 2023

@louisgv You could probably use the build.rs of your tauri project to copy the correct dlls/so files to an '\dlls' folder in your build target which you can then always include via an "resources": [dlls/*] definition in the tauri.conf.json. This would make building very simple and you don't need to change anything in your workflows.

@louisgv
Copy link
Owner

louisgv commented Jul 6, 2023

Will move this to v0.6.0

@louisgv louisgv changed the title [Bug] Can't run 0.5.1 on Windows, asks for additional dlls BUG | Can't run 0.5.1 on Windows, asks for additional dlls Jul 6, 2023
@louisgv louisgv pinned this issue Jul 14, 2023
@louisgv
Copy link
Owner

louisgv commented Jul 14, 2023

Moving it to 0.7.0 until I got my Windows box setup :d...

@LLukas22
Copy link
Collaborator

You should move it back until rustformers/llm#325 gets mergen, then i can take a look at including the dlls.

@step21
Copy link

step21 commented Jul 29, 2023

FYI - might also not be allowed to distribute them, assuming they are shipped by the Nvidia driver normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants