Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle CUDA DLL into the release #62

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

louisgv
Copy link
Owner

@louisgv louisgv commented Jul 2, 2023

No description provided.

@louisgv louisgv linked an issue Jul 2, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Jul 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
local-ai-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2023 11:49pm

@LLukas22
Copy link
Collaborator

Feeding.slowdown.mp4

@louisgv The callback to the UI of the fed tokens seams to slowdown the feeding process significantly. (Should be instant)

@louisgv
Copy link
Owner Author

louisgv commented Jul 20, 2023

The callback to the UI of the fed tokens seams to slowdown the feeding process significantly

Yes haha - there's a 42ms artificial lag that I introduced to make the UI a bit more smooth:

ref: https://github.com/louisgv/local.ai/blob/main/apps/desktop/src/providers/thread.ts#L160-L161

For non-accelerated machine and models, this is needed to have something showing :d.......

@LLukas22
Copy link
Collaborator

Currently this copies the cuda dlls next to the local.ai executable if the cargo tauri dev or cargo tauri build command is executed with the --features cublas flag. @louisgv Is this enought to include the dlls into the bundle?

@LLukas22
Copy link
Collaborator

@louisgv Whats the plan going forward on this? Can you take over and handle the auto update stuff?

@louisgv
Copy link
Owner Author

louisgv commented Jul 27, 2023

@LLukas22 yup, I'm on it now!

@louisgv louisgv mentioned this pull request Jul 31, 2023
@louisgv
Copy link
Owner Author

louisgv commented Sep 16, 2023

Kinda want to wait for the Metal fix to land. My main fear with this PR is that the build seems flaky :d.... (OOM?...)

Perhaps we should remove some of the flakyness by building for either cuda or CL only?...

@louisgv
Copy link
Owner Author

louisgv commented Sep 16, 2023

Per the docs, there's still no metal chips on github runner VM yet: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

So we will still need a metal self-hosted runner I think :d

@louisgv
Copy link
Owner Author

louisgv commented Sep 16, 2023

The last piece missing from this PR is a pipeline to upload the content of each zip artifact into a release.

  1. Extract the zip artifact of the 3 jobs (mac, linux, window)
  2. Have a 4th job called release, that's in charge of making a release and the update.json
  3. Take the path and the signature to form a Tauri update package: https://tauri.app/v1/guides/distribution/updater/#static-json-file
  4. Create the draft release

@louisgv louisgv added the help wanted Extra attention is needed label Sep 16, 2023
@louisgv louisgv self-assigned this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG | Can't run 0.5.1 on Windows, asks for additional dlls
2 participants