Expression parser #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the grammar
…thout error and end handling
loumadev
requested changes
Oct 30, 2023
src/compiler/parser/Expressions.c
Outdated
| return id; | ||
| } | ||
| if(id->token->type = TOKEN_IDENTIFIER){ | ||
| IdentifierASTNode *identifierE = new_IdentifierASTNode(id->token->value.string); //string or identifier? |
There was a problem hiding this comment.
Strings are being considered literals; This might not apply if the string is interpolated (we'll discuss this later).
The general idea is that when the string literal is encountered, some sub-procedure should trigger and match pattern like "string expression string ... string expression string". After each string, there should be either an expression (without any direct operator, "str" 2 + 3) or operator ("str" + 2 + 3), or some terminator (;, EOF, ...).
["str", 2, +, 3], should be parsed into:
StringLiteralExpression:
* StringLiteralSegmentList:
- StringSegment
* value: String* ("str")
- BinaryExpression
* left: ... (2)
* right: ... (3)
...
- StringSegment (string literal is guaranteed to end by string)
* value: String* ("")
Note: The strings can be nested: "pre\("in")post" -> ["pre", "in", "post"] ->
StringLiteralExpression [
StringSegment("pre"),
StringLiteralExpression [ StringSegment("in") ],
StringSegment("post")
]Notice: This feature is not currently available in the project, but will be implemented in the upcoming time.
…into expressionParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new AST nodes, functions for creating them, expression parsing wi
thout error and end handling