Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations.json with "ca" language #314

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

jbatlleb
Copy link
Contributor

Added Catalan translation (lang="ca", "ca-es") to translations.json.
The translation is complete.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

Added Catalan translation (lang="ca", "ca-es") to translations.json
@lovasoa
Copy link
Owner

lovasoa commented Jul 18, 2024

@jbatlleb : thanks ! It looks like there is a formatting issue in the translations file

Minor changes in Catalan (lang="ca").
@jbatlleb
Copy link
Contributor Author

I checked the file and couldn't locate any format errors...
Is there any other information I could get in order to adress the issue?
Thanks.

@lovasoa
Copy link
Owner

lovasoa commented Jul 18, 2024

You can format the file with npx prettier

Copy link
Contributor Author

@jbatlleb jbatlleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catalan translation's format in translations.json,

Removed a trailing whitespace that could be preventing the file for passing the format test.
@lovasoa lovasoa merged commit d494f30 into lovasoa:master Jul 18, 2024
4 checks passed
@lovasoa
Copy link
Owner

lovasoa commented Jul 18, 2024

Thank you for your contribution, it's included !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants