Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change request + Some new fancy tools + Alphabetic ordering (Per section) #277

Closed

Conversation

alejandro-alzate
Copy link
Contributor

@alejandro-alzate alejandro-alzate commented Jan 8, 2025

Cleaner commit of #274 this one includes commits that were stuck on the pipeline and the change request on #274.

From #274:

  • love godot base
  • love async await
  • Branch update

From #277 (this one):

  • slick
  • enum
  • gooey
  • lua-obor
  • ecamira
  • saveData
  • love_windows
  • love_instance (Apparently this is better than love_windows discussion open for those)
  • serverstuffs
  • Change request from MikuAuahDark

Other changes:

  • Ordered every section (Only the section contents)
    • Is this commit too big?
    • Is this commit spam okay? or is it better one new tool per commit?

@alejandro-alzate
Copy link
Contributor Author

Could I run the linter offline, like real time? It would be handy having grammar feedback realtime.

@alejandro-alzate
Copy link
Contributor Author

Ordered every category by alphabetic order.
Because I'm way too bored and wanted to suffer I guess...

@alejandro-alzate alejandro-alzate changed the title Change request + Some new fancy tools Change request + Some new fancy tools + Alphabetic ordering (Per section) Jan 8, 2025
@MikuAuahDark
Copy link
Member

MikuAuahDark commented Jan 8, 2025

This PR is way worse than the original one.

My main concern with the original PR is "love-godot-base" doesn't fit in any of awesome-love2d categories for now (feel free to create an issue for a new category and put love-godot-base as an example). The reason is love-gotot-base is quite big to be called a library on its own. They're more like a template instead of standalone library. That's why my original request with the original PR is to simply remove love-godot-base.

What's making this worse is it's noisy due to library reordering. This is currently unnecessary right now. However, if you really want to reorder libraries, please do them in another PR.

@alejandro-alzate
Copy link
Contributor Author

Understood, can you apply a particular commit like 8ea5c4e on github, is that a thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants