-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMPORTANT: Changes to /sdcard/lovegame Functionality #194
Comments
See love2d#194 This also mean that external storage permission is only requested only when running Marshmallow or earlier.
* Update dependencies and target SDK * Update Gradle to 6.6.1 * Update target API level to 30 * Update AGP to 4.0.1 * Update Android Build Dependencies (androidx.appcompat:appcompat:1.2.0, androidx.multidex:multidex:2.0.1) * Update readme * Move /sdcard/lovegame directory. (closes #194) * Potentially fixes black screen when reopening LOVE from app drawer (fixes #190) * Downloader cleanup. * Merge SDL AndroidManifest.xml to LOVE * Implement partial "Share to LOVE" support. * Enable resizeableActivity
…mpatibility. See #194 for further explanation about this change.
Is this changed in main? Also why did you say other apps can't access that directory? They can |
Yes. This changes has been in |
Strange something must be wrong with my tablet then on android 11 using material files I can access android/data files just fine of other apps. Just tested on my phone appears it doesn't work there strange |
Out of curiosity what stops love2d with external access to read files to use for the game? |
Sorry for the questions I use android as my main computer so these changes are concerning for my workflow. If you don't want to spam this github issue is there anywhere I can dm you? |
I'm not quite sure what do you mean, but if you read my writings on top of this issue, you should be able to know why. Please let me know if something's not clear about it. |
I somewhat understand I've read about scoped storage changes however what I don't understand is apps can still access /sdcard so why can't they run the lua files since the interpreter itself is in the apk. Sorry I'm pretty dumb just a little confused |
File Managers are allowed to access |
What if we were to have two versions a fdroid/github one and a Google play one? |
Or even a define flag somewhere? I'm sure most people using love on android in a non emvedded way wouldn't mind installing outside of Google play |
We already have GitHub and Google Play variants. The Google Play variants doesn't support audio recording while the GitHub variant supports it. I plan to distribute for F-Droid but I was too busy to setup the repository such that it's F-Droid compatible. Anyway, While writing this, it seems I break this change, so I'm now debugging it. |
I use android as my main dev environment so zipping up the files everytime to debug my game or compiling everytime(through termux) is annoying to say the least. Where as I can have live reload if it's in /sdcard/love game. I know it's a privacy concern but for me to just debug it would be nice. I'm testing out the permission right now |
Yeah fair enough I'll see if I can't just edit the source code myself. Really doubting my decision to use android lol thx for the tips on the file manager thing though maybe it'll help me out. |
…okup. See #194 for more information.
Also just wondering if android isn't supported why make a game selector? |
Because writing games in PC then copying it over to your phone is the
intended way to do it. This is also true for LOVE iOS. I have thinking
about the necessary details but game selector is 12.0 specific.
Pada tanggal Sel, 28 Des 2021 16.52, Vixeliz ***@***.***>
menulis:
… Also just wondering if android isn't supported why make a game selector?
—
Reply to this email directly, view it on GitHub
<#194 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZHFFQ7XWZJX2FMOYBYBADUTF3FLANCNFSM4SAPMXPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
One last question. I know I won't get any support but if you know it's a simple question. Using MANAGE_EXTERNAL_STORAGE if I can figure out how to do it myself should I be able to get it to read from /sdcard/lovegame? |
Yes, but you must request the permission at runtime like what it does prior
this change. You have to recompile it yourself though.
Pada tanggal Sel, 28 Des 2021 17.00, Vixeliz ***@***.***>
menulis:
… One last question. I know I won't get any support but if you know it's a
simple question. Using MANAGE_EXTERNAL_STORAGE if I can figure out how to
do it myself should I be able to get it to read from /sdcard/lovegame?
—
Reply to this email directly, view it on GitHub
<#194 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZHFFRWYBG24PSR3NQY76TUTF4CPANCNFSM4SAPMXPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Alright thank you. I tried to figure it out but I'm not familiar with android dev so I may try to find an alternative solution thanks for answering questions even though it's unsupported |
I do have one last question I swear this is the last one. Why do you have no interest in supporting android as a dev environment right now love is one of the few options there is for android game dev. I am going to try to fork the love-android repo with some minimal changes to hopefully make it more possible to do so. But from what I understand there is no interest to accept said changes to master even as options? |
Because using Android as development is (probably) never a supported scenario in general(?) (i.e. Google doesn't intend us to use Android as developing environment). You see, Android was used to allow any files access. However due to privacy concern, in Android 6, apps must ask user for such external storage access. Then further, using Of course they realize that user may need to access
|
If anyone is reading this since this is pinned if the pr #230 get's accepted this will be a non issue as any apps that support android's storage access framework will allow love files to be edited again. |
Actually, there is a third option. |
When you try to run LOVE Android compiled at f0abf9b, and you're using the "normal" or "playstore" flavor, and you want to run games from
/sdcard/lovegame
, you'll see this error.Turns out this is caused by Android 10 scoped storage restictions. It's possible to opt-out for this change but then Android 11 will force it for all apps that targets API 30 and later.
Sadly this mean the only possible solution is to move
/sdcard/lovegame
to somewhere else like/sdcard/Android/data/org.love2d.android/games/lovegame
. Unfortunately even with this change, apps inside the phone won't able to access that directory at all and the only way to access those directories is by plugging the phone to the computer. This is breaking change but this is also inevitable.That behavior is basically how LOVE iOS behaves, according to slime explanation in Discord. If this gonna end up like LOVE iOS, then I may have reason to develop game selector for LOVE 12.0.
TL;DR:
/sdcard/lovegame
no longer works in Android 10 and later and will be moved to/sdcard/Android/data/org.love2d.android/files/games/lovegame
.This issue will be closed once I moved the directories. Any suggestion or critism is welcome.
EDIT: To provide backward compatibility at some extent, LOVE will also look at
/sdcard/lovegame
in Android 9 and earlier.The text was updated successfully, but these errors were encountered: