testsuite updates #2043
Merged
testsuite updates #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ellraiser
commented
Mar 22, 2024
ellraiser
commented
- added some additional checks to check for lua version/jit enabled for use with other repos (namely love potion)
- graphics tests will now show a third "difference" image if the test fails to help identify what pixels do not match up
- updated HTML report styling to group each image compare, fix pixel rendering, add hover zoom to comparisons, add collapsible regions (failed modules opened by default), and make pass/fails per module clearer
- fixed not showing image checks for the 4th compareImg or more in a given test method
- fixed pixel tolerance usage crashing when looking at images on the boundary
- fixed compare img not checking the first 2 rows of pixels on the x + y
- changed examples to include a couple failures so people can see how that would look
- added some additional checks to check for lua version/jit enabled for use with other repos (namely love potion) - updated HTML report CSS to group each image compare and fix pixel rendering - fixed not showing image checks for the 4th compareImg or more in a given test method - fixed pixel tolerance usage crashing when looking at images on the boundary - fixed compare img not checking the first 2 rows of pixels on the x + y -graphic tests that fail will now show a third "difference" image to help identify what isn't matching up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.