Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embeded SVG rendering #293

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

eduardomozart
Copy link
Contributor

@eduardomozart eduardomozart commented May 10, 2023

Fixes message "Error: Non-static method ODTImage::addStringAsSVGImage() cannot be called statically" on PHP 8.1 as can be seen in #274 and schplurtz/a2s#13
This method is also used by other plug-ins like switchpanel - https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel/blob/561d049aef21afb3d54406d1b62373e8275ce766/syntax.php#L460 - and plantumlparser - kylec32/dokuwiki_plantumlparser#43

Fixes message "Error: Non-static method ODTImage::addStringAsSVGImage() cannot be called statically" on PHP 8.1 as can be seen in lpaulsen93#274
It's also used by other plug-ins like switchpanel - https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel/blob/561d049aef21afb3d54406d1b62373e8275ce766/syntax.php#L460
@Klap-in Klap-in merged commit 24566a5 into lpaulsen93:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants