Sync interfaces/ with @webref/idl 2.2.6 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
49b67e3 to
330a00d
Compare
lpd-au
pushed a commit
that referenced
this pull request
Jun 15, 2021
1. Only process ChildrenChanged() for the included root of a change. For example, if a <div id="root" style="display:none"> will be included because it is a potential relation target. If descendants change, the only ChildrenChanged() necessary to process is on #root. 2. Share common code for detaching a node and queuing up the appropriate children changes. This simplifies ProcessInvalidatedObjects() by removing one of the inner loops, and enables a follow-up CL to remove the outer loop as well. #1 results in a massive speedup for display none toggles. In combination with other recent changes in DetachAndRemoveFromChildrenOfAncestors(), is 7x faster for many-nodes-toggle-display-none in perf_tests . This change alone accounts for about half of the overall improvement. Follow-ups: - Restore lifecycle check by processing deferred children changes via nodes_with_pending_children_changed_ and not queuing via the traditional mechanism. While doing this, look for opportunities to consolidate more children changed events. - Remove outer loop from ProcessInvalidatedObjects(). Bug: None Change-Id: I80466fda792cd0ca6dd051065a42ba702e4cc8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946971 Reviewed-by: Dominic Mazzoni <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/master@{#891343}
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
330a00d to
03a43be
Compare
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
03a43be to
c18a385
Compare
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
c18a385 to
ec47c4f
Compare
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
ec47c4f to
792aee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automated pull request updates interfaces/*.idl from @webref/idl 2.2.6.
Before merging, please check that any tests that depend on the updated IDL files still work.
If additional changes are needed, please manually create another PR based on this one.
See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.