Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support-o_nif_cc] Support o_nif_cc gpb_opt #163

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tak30
Copy link

@tak30 tak30 commented Feb 13, 2023

This PR bumbs the gpb version to the latest and adds support to the o_nif_cc option.

@tak30 tak30 marked this pull request as draft February 13, 2023 11:47
@tak30 tak30 marked this pull request as ready for review February 22, 2023 10:15
@tak30
Copy link
Author

tak30 commented Feb 22, 2023

@lrascao Could you take a look a this change? Thanks!!

rebar.config Outdated Show resolved Hide resolved
@@ -30,10 +31,17 @@ compile(AppInfo, State) ->
TargetHrlDir = filename:join([AppOutDir,
proplists:get_value(o_hrl, GpbOpts0,
?DEFAULT_OUT_HRL_DIR)]),
TargetNifDir = filename:join([AppOutDir,
proplists:get_value(o_nif_cc, GpbOpts0,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that people not interested in NIF generation will get it anyway?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, by default the NIF generation would be off

Copy link
Author

@tak30 tak30 Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What they would get is the priv folder. Maybe we shouldn't create that folder by default. What do you think @lrascao ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, if it can be avoided that would be best, always good to avoid unexpected things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants