Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added topic to track pixel position of the center of marker #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

badrobot15
Copy link

Added a topic /circle_center to track pixel coordinate of the center of the whycon marker. Useful for working with other type of markers by maintaing a single coordinate frame of reference i.e. the pixel location

@protobits
Copy link
Contributor

Hi, I'm looking at your PR.
Sorry, but as it is it does not make sense: you are assuming that you have a single target (you assign the same variable inside the loop for every target). Moreover, there are unrelated changes (setting number of targets) included.
I'm not entirely against the idea of publishing image position of targets, but to accept it it would need to be correctly implemented. In other words, you can publish a pose array as with the poses but setting z = 1. Also, remove the target number setting since this is not related to this PR.

@badrobot15
Copy link
Author

Thanks for pointing that out. I have made the required changes.
Setting the number of targets is a useful feature and hoping to see it get added in the master soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants