add validation

ls1intum · Sep 7, 2024 · fb6a128 · fb6a128
1 parent 306e346
commit fb6a128
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/main/java/de/tum/cit/ase/artemistelemetry/service/TelemetryService.java b/src/main/java/de/tum/cit/ase/artemistelemetry/service/TelemetryService.java
@@ -2,6 +2,7 @@
 
 import de.tum.cit.ase.artemistelemetry.domain.Telemetry;
 import de.tum.cit.ase.artemistelemetry.repository.TelemetryRepository;
+import de.tum.cit.ase.artemistelemetry.service.dto.TelemetryDTO;
 import org.springframework.stereotype.Service;
 
 import java.time.ZonedDateTime;
@@ -48,4 +49,19 @@ public Telemetry updateTelemetryByUniversityName(Telemetry newTelemetry) {
         newTelemetry.setId(telemetry.getId());
         return telemetryRepository.save(newTelemetry);
     }
+
+    public void validateTelemetry(TelemetryDTO telemetry) throws IllegalArgumentException {
+        if (telemetry.operator() == null || telemetry.operator().isEmpty()) {
+            throw new IllegalArgumentException("University name must not be empty");
+        }
+        if (telemetry.profiles() == null || telemetry.profiles().isEmpty()) {
+            throw new IllegalArgumentException("Profiles must not be empty");
+        }
+        if (telemetry.serverUrl() == null || telemetry.serverUrl().isEmpty()) {
+            throw new IllegalArgumentException("Server URL must not be empty");
+        }
+        if (telemetry.version() == null || telemetry.version().isEmpty()) {
+            throw new IllegalArgumentException("Version must not be empty");
+        }
+    }
 }
diff --git a/src/main/java/de/tum/cit/ase/artemistelemetry/web/rest/TelemetryResource.java b/src/main/java/de/tum/cit/ase/artemistelemetry/web/rest/TelemetryResource.java
@@ -24,7 +24,12 @@ public ResponseEntity<TelemetryDTO> getTelemetry(@PathVariable Long id) {
     }
 
     @PostMapping
-    public ResponseEntity<TelemetryDTO> postTelemetry(@RequestBody TelemetryDTO telemetryDTO) {
+    public ResponseEntity<?> createTelemetry(@RequestBody TelemetryDTO telemetryDTO) {
+        try {
+            telemetryService.validateTelemetry(telemetryDTO);
+        } catch (IllegalArgumentException e) {
+            return ResponseEntity.status(400).body(e.getMessage());
+        }
         Telemetry savedTelemetry = telemetryService.saveNewTelemetry(TelemetryDTO.to(telemetryDTO));
         return ResponseEntity.ok(TelemetryDTO.from(savedTelemetry));
     }