Development: Improve server code

ls1intum · Jan 7, 2024 · 70d1f58 · 70d1f58
1 parent 00d9172
commit 70d1f58
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/main/java/de/tum/in/www1/artemis/domain/quiz/DragAndDropQuestion.java b/src/main/java/de/tum/in/www1/artemis/domain/quiz/DragAndDropQuestion.java
@@ -177,7 +177,7 @@ public void onDelete() {
         }
         catch (FilePathParsingException e) {
             // if the file path is invalid, we don't need to delete it
-            log.warn("Could not delete file with path {}. Assume already deleted, entity can be removed.", backgroundFilePath, e);
+            log.warn("Could not delete file with path {}. Assume already deleted, DragAndDropQuestion {} can be removed.", backgroundFilePath, getId());
         }
     }
 

diff --git a/src/main/java/de/tum/in/www1/artemis/domain/quiz/DragItem.java b/src/main/java/de/tum/in/www1/artemis/domain/quiz/DragItem.java
@@ -144,7 +144,7 @@ public void onDelete() {
         }
         catch (FilePathParsingException e) {
             // if the file path is invalid, we don't need to delete it
-            log.warn("Could not delete file with path {}. Assume already deleted, entity can be removed.", pictureFilePath, e);
+            log.warn("Could not delete file with path {}. Assume already deleted, DragAndDropQuestion {} can be removed.", pictureFilePath, getId());
         }
     }
 

diff --git a/src/test/java/de/tum/in/www1/artemis/localvcci/LocalVCLocalCITestService.java b/src/test/java/de/tum/in/www1/artemis/localvcci/LocalVCLocalCITestService.java
@@ -301,7 +301,7 @@ public String constructLocalVCUrl(String username, String projectKey, String rep
      * @return the URL to the repository.
      */
     public String constructLocalVCUrl(String username, String password, String projectKey, String repositorySlug) {
-        return "http://" + username + (password.length() > 0 ? ":" : "") + password + (username.length() > 0 ? "@" : "") + "localhost:" + port + "/git/" + projectKey.toUpperCase()
+        return "http://" + username + (!password.isEmpty() ? ":" : "") + password + (!username.isEmpty() ? "@" : "") + "localhost:" + port + "/git/" + projectKey.toUpperCase()
                 + "/" + repositorySlug + ".git";
     }
 

diff --git a/src/test/resources/config/application.yml b/src/test/resources/config/application.yml
@@ -175,22 +175,22 @@ zonky:
                         enabled: true
                 server:
                     properties:
-                        max_connections: 10
-                        shared_buffers: 1GB
-                        effective_cache_size: 3GB
+                        max_connections: 100
+                        shared_buffers: 2GB
+                        effective_cache_size: 4GB
                         maintenance_work_mem: 256MB
                         checkpoint_completion_target: 0.9
                         wal_buffers: 16MB
                         default_statistics_target: 100
                         random_page_cost: 1.1
                         effective_io_concurrency: 200
-                        work_mem: 26214kB
+                        work_mem: 16MB
                         min_wal_size: 1GB
                         max_wal_size: 4GB
-                        max_worker_processes: 4
-                        max_parallel_workers_per_gather: 2
-                        max_parallel_workers: 4
-                        max_parallel_maintenance_workers: 2
+                        max_worker_processes: 8
+                        max_parallel_workers_per_gather: 4
+                        max_parallel_workers: 8
+                        max_parallel_maintenance_workers: 4
             mysql:
                 docker:
                     image: "mysql:8.2.0"