Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Add recents section to sidebar #10033

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

asliayk
Copy link
Contributor

@asliayk asliayk commented Dec 16, 2024

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

  • As decided, conversations marked as favorites should not only appear in the "Favorites" section but also remain at the top of their respective sections.
  • To provide easier access to conversations that are more relevant or frequently needed by the user, a new "Currently Important" section should be introduced. This section should include channels linked to recent lectures, exercises, and exams, allowing users to find these conversations faster. (Closes Communication: Add sub-groups to communication channels.  #9621)

Description

  • Favorites now also appear at the top of their respective sections, in addition to the "Favorites" section.
  • A new section called "Recents" has been added just below the "Favorites" section. This section includes channels from a time range of 1.5 weeks before to 1.5 weeks after the current date. For lectures and exams, the startDate is used as the reference, while for exercises, the dueDate and releaseDate are considered.
  • Unused code related to ChannelAccordionShowAdd has been removed.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course with Communication enabled
  1. Log in to Artemis
  2. Navigate to a course that has at least one exam/lecture that started no earlier than 1.5 weeks ago or an exercise with a due date no later than 1.5 weeks from now.
  3. Navigate to its communication section and notice the new section called "Recents" with its related channels
  4. Favorite a random channel and notice that it appears at the top of its related section in addition to being listed under the Favorites section.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Class/File Line Coverage Confirmation (assert/expect)
course-conversations.component.ts 90.76% ✅ ❌
course-overview.service.ts 92.77% ✅ ❌
sidebar.component.ts 91.66% ✅ ❌
sidebar.ts not found (modified)

Screenshots

image

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new "recents" channel type for improved conversation categorization.
    • Added localization support for "recents" in both English and German.
  • Bug Fixes

    • Enhanced conditional rendering logic for sidebar components, ensuring proper visibility based on user interactions.
  • Documentation

    • Updated tests to reflect new functionalities and ensure robust coverage for the course conversations component.
  • Chores

    • Removed unused properties and streamlined event handling in the sidebar component.

@asliayk asliayk added tests client Pull requests that update TypeScript code. (Added Automatically!) component:Communication labels Dec 16, 2024
@asliayk asliayk self-assigned this Dec 16, 2024
@asliayk asliayk requested a review from a team as a code owner December 16, 2024 19:43
@asliayk asliayk marked this pull request as draft December 16, 2024 19:44
Copy link

coderabbitai bot commented Dec 16, 2024

Walkthrough

This pull request introduces enhancements to the course conversations and sidebar functionality in an Angular application. The changes focus on improving the rendering logic for conversations, adding a new "recents" channel type, and refining the sidebar component's event handling. Key modifications include updating the conversation grouping mechanism, adding localization for the "recents" label, and simplifying the sidebar's input properties. The changes aim to provide a more intuitive and context-aware user experience for course-related conversations.

Changes

File Change Summary
src/main/webapp/app/overview/course-conversations/course-conversations.component.html Refined conditional rendering for code of conduct and conversation components.
src/main/webapp/app/overview/course-conversations/course-conversations.component.ts Added recents channel type, updated sidebar data preparation methods.
src/main/webapp/app/overview/course-overview.service.ts Modified conversation grouping and mapping methods to include course context.
src/main/webapp/app/shared/sidebar/sidebar.component.ts Removed showAddOption input, updated event emitters and input declarations.
src/main/webapp/app/types/sidebar.ts Added 'recents' to ChannelGroupCategory, introduced isCurrent property.
src/main/webapp/i18n/de/student-dashboard.json Added German translation for "recents".
src/main/webapp/i18n/en/student-dashboard.json Added English translation for "recents".

Assessment against linked issues

Objective Addressed Explanation
Add sub-groups to communication channels (#9621)
Improve sidebar functionality and user experience

Possibly related PRs

  • Communication: Improve sidebar user interface design #9356: The changes in this PR involve significant modifications to the course-conversations.component.html and course-conversations.component.ts, which directly relate to the sidebar's functionality and user interactions, similar to the adjustments made in the main PR regarding the sidebar's rendering logic.

  • Communication: Always show favorite channels #9510: This PR focuses on enhancing the sidebar's visibility control by removing empty channels, which aligns with the main PR's changes that refine the sidebar's rendering based on user interactions and conditions.

  • Communication: Add unread message notification icon to sidebar accordion #9737: The introduction of unread message notifications in the sidebar accordion is relevant as it enhances the user interface in a manner that complements the changes made in the main PR, which also focuses on improving the sidebar's functionality and user experience.

  • Development: Migrate client code for conversation detail tabs #9973: The migration of client code for conversation detail tabs to a more reactive model aligns with the main PR's focus on improving component interactions and user experience, as both aim to enhance the application's responsiveness and maintainability.

Suggested labels

small, ready to merge

Suggested reviewers

  • JohannesWt
  • rabeatwork
  • HawKhiem
  • florian-glombik
  • sachmii
  • FelberMartin
  • anian03

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (4)
src/main/webapp/app/overview/course-overview.service.ts (3)

174-193: Consider renaming 'getConversationGroup' to 'getConversationGroups'

Since the method now returns an array of ChannelGroupCategory, renaming it to getConversationGroups would improve readability and accurately reflect its functionality.


230-230: Add JSDoc comments for the updated method signature

Consider adding or updating the documentation for groupConversationsByChannelType to reflect the new course parameter, explaining its purpose and usage.


294-294: Add JSDoc comments for the updated method signature

Consider adding or updating the documentation for mapConversationsToSidebarCardElements to reflect the new course parameter, explaining its purpose and usage.

src/main/webapp/app/types/sidebar.ts (1)

139-139: Add documentation for 'isCurrent' property

Consider adding a JSDoc comment to the isCurrent property in the SidebarCardElement interface to explain its purpose, enhancing code readability and maintainability.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5449cc4 and 4e30d18.

📒 Files selected for processing (9)
  • src/main/webapp/app/overview/course-conversations/course-conversations.component.html (0 hunks)
  • src/main/webapp/app/overview/course-conversations/course-conversations.component.ts (7 hunks)
  • src/main/webapp/app/overview/course-overview.service.ts (7 hunks)
  • src/main/webapp/app/shared/sidebar/sidebar.component.ts (1 hunks)
  • src/main/webapp/app/types/sidebar.ts (2 hunks)
  • src/main/webapp/i18n/de/student-dashboard.json (1 hunks)
  • src/main/webapp/i18n/en/student-dashboard.json (1 hunks)
  • src/test/javascript/spec/component/course/course-overview.service.spec.ts (3 hunks)
  • src/test/javascript/spec/component/overview/course-conversations/course-conversations.component.spec.ts (4 hunks)
💤 Files with no reviewable changes (1)
  • src/main/webapp/app/overview/course-conversations/course-conversations.component.html
✅ Files skipped from review due to trivial changes (1)
  • src/main/webapp/i18n/en/student-dashboard.json
👮 Files not reviewed due to content moderation or server errors (3)
  • src/main/webapp/app/overview/course-conversations/course-conversations.component.ts
  • src/test/javascript/spec/component/course/course-overview.service.spec.ts
  • src/test/javascript/spec/component/overview/course-conversations/course-conversations.component.spec.ts
🧰 Additional context used
📓 Path-based instructions (7)
src/main/webapp/i18n/de/student-dashboard.json (1)

Pattern src/main/webapp/i18n/de/**/*.json: German language translations should be informal (dutzen) and should never be formal (sietzen). So the user should always be addressed with "du/dein" and never with "sie/ihr".

src/main/webapp/app/types/sidebar.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

src/main/webapp/app/shared/sidebar/sidebar.component.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

src/main/webapp/app/overview/course-conversations/course-conversations.component.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

src/test/javascript/spec/component/overview/course-conversations/course-conversations.component.spec.ts (1)

Pattern src/test/javascript/spec/**/*.ts: jest: true; mock: NgMocks; bad_practices: avoid_full_module_import; perf_improvements: mock_irrelevant_deps; service_testing: mock_http_for_logic; no_schema: avoid_NO_ERRORS_SCHEMA; expectation_specificity: true; solutions: {boolean: toBeTrue/False, reference: toBe, existence: toBeNull/NotNull, undefined: toBeUndefined, class_obj: toContainEntries/toEqual, spy_calls: {not_called: not.toHaveBeenCalled, once: toHaveBeenCalledOnce, with_value: toHaveBeenCalledWith|toHaveBeenCalledExactlyOnceWith}}

src/test/javascript/spec/component/course/course-overview.service.spec.ts (1)

Pattern src/test/javascript/spec/**/*.ts: jest: true; mock: NgMocks; bad_practices: avoid_full_module_import; perf_improvements: mock_irrelevant_deps; service_testing: mock_http_for_logic; no_schema: avoid_NO_ERRORS_SCHEMA; expectation_specificity: true; solutions: {boolean: toBeTrue/False, reference: toBe, existence: toBeNull/NotNull, undefined: toBeUndefined, class_obj: toContainEntries/toEqual, spy_calls: {not_called: not.toHaveBeenCalled, once: toHaveBeenCalledOnce, with_value: toHaveBeenCalledWith|toHaveBeenCalledExactlyOnceWith}}

src/main/webapp/app/overview/course-overview.service.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

🔇 Additional comments (5)
src/main/webapp/app/overview/course-overview.service.ts (3)

23-23: Import of 'Course' is appropriate

The import of Course is necessary for the updated method signatures and is correctly added.


62-62: Addition of 'recently' group is appropriate

The inclusion of the recently group in DEFAULT_CHANNEL_GROUPS correctly aligns with the new functionality and is properly initialized.


265-267: Ensure all group names are valid keys in 'groupedConversationGroups'

Verify that all group names returned by getConversationGroup are valid keys in groupedConversationGroups to prevent potential runtime errors.

Run the following script to check for any group names not present in groupedConversationGroups:

✅ Verification successful

Based on the gathered information, I can now provide the final response:

The group names are safely typed and validated by the TypeScript type system

The code is safe because:

  • getConversationGroup() only returns valid ChannelGroupCategory values: 'favoriteChannels', 'hiddenChannels', 'groupChats', and 'directMessages'
  • These values are all included in the ChannelGroupCategory type definition
  • The groupedConversationGroups is initialized from channelGroups which is typed as AccordionGroups
  • TypeScript's type system ensures that the group names used as keys are valid
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all group names are valid keys in 'groupedConversationGroups'

# Extract all possible group names from 'ChannelGroupCategory'
echo "Possible group names:"
grep -oP "(?<=\| ')[^']+" src/main/webapp/app/types/sidebar.ts

# Extract group names used in 'getConversationGroup' method
echo "Group names used in 'getConversationGroup' method:"
grep -oP "groups\.push\('([^']+)'\)" src/main/webapp/app/overview/course-overview.service.ts | awk -F"'" '{print $2}'

# Compare group names
echo "Group names not present in 'groupedConversationGroups':"
comm -23 \
  <(grep -oP "groups\.push\('([^']+)'\)" src/main/webapp/app/overview/course-overview.service.ts | awk -F"'" '{print $2}' | sort | uniq) \
  <(grep -oP "(?<=\| ')[^']+" src/main/webapp/app/types/sidebar.ts | sort | uniq)

Length of output: 1155


Script:

#!/bin/bash
# Let's verify this in a different way by checking the actual implementation

# First, let's see how groupedConversationGroups is initialized
echo "Initialization of groupedConversationGroups:"
rg -A 5 "groupedConversationGroups\s*=" src/main/webapp/app/overview/course-overview.service.ts

# Then, let's see the full implementation of getConversationGroup
echo -e "\nImplementation of getConversationGroup:"
ast-grep --pattern 'getConversationGroup($_) {
  $$$
}'

# Finally, let's check where conversationGroups comes from
echo -e "\nUsage context of conversationGroups:"
rg -B 5 -A 5 "const group of conversationGroups" src/main/webapp/app/overview/course-overview.service.ts

Length of output: 1220


Script:

#!/bin/bash
# Let's check the initialization of channelGroups and the getConversationGroup method

# Check where channelGroups is defined/initialized
echo "channelGroups initialization:"
rg -B 2 -A 2 "channelGroups\s*=" src/main/webapp/app/overview/course-overview.service.ts

# Get the full getConversationGroup method implementation
echo -e "\ngetConversationGroup method:"
rg -B 2 -A 15 "getConversationGroup.*\{" src/main/webapp/app/overview/course-overview.service.ts

# Check the type definition of channelGroups
echo -e "\nType definitions:"
rg "type.*AccordionGroups" src/main/webapp/app/types/sidebar.ts -A 5

Length of output: 1744


Script:

#!/bin/bash
# Let's check the DEFAULT_CHANNEL_GROUPS definition and ChannelGroupCategory type

# Check DEFAULT_CHANNEL_GROUPS initialization
echo "DEFAULT_CHANNEL_GROUPS definition:"
rg "DEFAULT_CHANNEL_GROUPS\s*=" -A 10 src/main/webapp/app/overview/course-overview.service.ts

# Get the complete ChannelGroupCategory type definition
echo -e "\nComplete ChannelGroupCategory definition:"
rg "ChannelGroupCategory.*=" -A 15 src/main/webapp/app/types/sidebar.ts

Length of output: 930

src/main/webapp/app/types/sidebar.ts (1)

19-19: Addition of 'recently' to 'ChannelGroupCategory'

The inclusion of 'recently' in the ChannelGroupCategory type is appropriate and aligns with the new functionality.

src/main/webapp/i18n/de/student-dashboard.json (1)

85-85: Translation added correctly with appropriate informal language

The key "recently": "Kürzlich" is added correctly and follows the guideline of using informal language (duzen) in German translations.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 16, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/main/webapp/app/overview/course-overview.service.ts (1)

Line range hint 232-278: Consider adding parameter validation.

While the implementation correctly handles favorite sorting and group organization, consider adding validation for the course parameter to prevent potential runtime errors.

 groupConversationsByChannelType(course: Course, conversations: ConversationDTO[], messagingEnabled: boolean): AccordionGroups {
+    if (!course) {
+        throw new Error('Course parameter is required for conversation grouping');
+    }
     const channelGroups = messagingEnabled ? { ...DEFAULT_CHANNEL_GROUPS, groupChats: { entityData: [] }, directMessages: { entityData: [] } } : DEFAULT_CHANNEL_GROUPS;
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e30d18 and a3e27b2.

📒 Files selected for processing (2)
  • src/main/webapp/app/overview/course-overview.service.ts (7 hunks)
  • src/test/javascript/spec/component/course/course-overview.service.spec.ts (4 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
src/test/javascript/spec/component/course/course-overview.service.spec.ts (1)

Pattern src/test/javascript/spec/**/*.ts: jest: true; mock: NgMocks; bad_practices: avoid_full_module_import; perf_improvements: mock_irrelevant_deps; service_testing: mock_http_for_logic; no_schema: avoid_NO_ERRORS_SCHEMA; expectation_specificity: true; solutions: {boolean: toBeTrue/False, reference: toBe, existence: toBeNull/NotNull, undefined: toBeUndefined, class_obj: toContainEntries/toEqual, spy_calls: {not_called: not.toHaveBeenCalled, once: toHaveBeenCalledOnce, with_value: toHaveBeenCalledWith|toHaveBeenCalledExactlyOnceWith}}

src/main/webapp/app/overview/course-overview.service.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

🔇 Additional comments (3)
src/main/webapp/app/overview/course-overview.service.ts (2)

62-62: LGTM: Addition of 'recently' group aligns with requirements.

The addition of the 'recently' group to DEFAULT_CHANNEL_GROUPS is consistent with the PR objective to add a "Recently" section to the sidebar.


174-195: LGTM: Well-structured implementation of multi-group support.

The refactored method now correctly supports conversations appearing in multiple groups (e.g., both in favorites and their original category) while maintaining a clear precedence order:

  1. Hidden channels
  2. Favorite channels
  3. Type-based categorization
src/test/javascript/spec/component/course/course-overview.service.spec.ts (1)

483-528: LGTM: Comprehensive test coverage for new functionality.

The test suite effectively covers all key aspects of the new functionality:

  • Favorite conversation handling (lines 483-498)
  • Date-based filtering for the "Recently" section (lines 500-528)

The test cases are well-structured and provide good coverage of edge cases.

src/main/webapp/app/overview/course-overview.service.ts Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 16, 2024
@asliayk
Copy link
Contributor Author

asliayk commented Dec 19, 2024

thank you for your reviews :) Based on your suggestions, I made the following changes:

  • For exercises, not only dueDate but also releaseDate is considered now.
  • "Recently" has been renamed to "Recents".

I appreciate your reviews once again :)

Copy link

@sachmii sachmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1, works fine

Copy link

@kevinfischer4 kevinfischer4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1, works as described.
image

Copy link
Member

@anian03 anian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Communication feature ready for review tests
Projects
Status: Ready For Review
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Communication: Add sub-groups to communication channels.