Development
: Display more in-depth health information about the hermes service
#10068
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Motivation and Context
Currently, Artemis checks if Hermes is running by calling the base url and looking if it returns a 200 response code. While working, this does not provide a lot of information to the admins.
Description
I implemented a new
/api/health
api in the Hermes Repository that provides the information whether or not Hermes was able to connect to the APNS or to Firebase. Additionally, it returns the version number of Hermes. This information is displayed in the "details" section when viewing the service health in the admin panel.Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Screenshots